Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102859: Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP #102870

Merged
merged 9 commits into from
Mar 22, 2023
Merged

gh-102859: Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP #102870

merged 9 commits into from
Mar 22, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Mar 21, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Mar 21, 2023
Closed
@iritkatriel iritkatriel mentioned this pull request Mar 21, 2023
Closed
@iritkatriel iritkatriel marked this pull request as draft March 21, 2023 12:24
@iritkatriel
Copy link
Member Author

There's still a problem with the peepholer. Converting to draft.

@iritkatriel iritkatriel marked this pull request as ready for review March 21, 2023 14:40
carljm
carljm approved these changes Mar 21, 2023
View reviewed changes
@iritkatriel
Copy link
Member Author

Thanks, I’ll wait for benchmark results before merging.

@markshannon
Copy link
Member

https://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20230322-3.12.0a6+-b2bf829

markshannon
markshannon approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this to cause a slowdown, but it seems the slowdown is negligible.

I expect that we will be able to get all that back and more with the optimizations discussed in the issue.

@iritkatriel iritkatriel added interpreter-core (Objects, Python, Grammar, and Parser dirs) 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Mar 22, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit b2bf829 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 22, 2023
@iritkatriel
Copy link
Member Author

refleak check passed.

@iritkatriel iritkatriel merged commit 3468c76 into python:main Mar 22, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@iritkatriel @Fidget-Spinner
pythongh-102859: Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP (p…
27f390b 
…ython#102870)
@iritkatriel iritkatriel deleted the remove-JUMP_IF_FALSE_OR_POP branch April 3, 2023 17:42
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@iritkatriel @warsaw
pythongh-102859: Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP (p…
3b6ada4 
…ython#102870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

@markshannon markshannon markshannon approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP
4 participants
@iritkatriel @markshannon @bedevere-bot @carljm