-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: improve accuracy of pdb alias example #102892
Merged
erlend-aasland
merged 1 commit into
python:main
from
gaogaotiantian:pdb-alias-doc-improve
Mar 22, 2023
Merged
Docs: improve accuracy of pdb alias example #102892
erlend-aasland
merged 1 commit into
python:main
from
gaogaotiantian:pdb-alias-doc-improve
Mar 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related (and out of scope for this PR): IMO, the pdb docs should be updated to use doctests, so we'll catch non-working examples in the docs. |
erlend-aasland
approved these changes
Mar 22, 2023
Thanks @gaogaotiantian for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
GH-102906 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 22, 2023
(cherry picked from commit e0c63b7) Co-authored-by: gaogaotiantian <gaogaotiantian@hotmail.com>
GH-102907 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 22, 2023
(cherry picked from commit e0c63b7) Co-authored-by: gaogaotiantian <gaogaotiantian@hotmail.com>
miss-islington
added a commit
that referenced
this pull request
Mar 22, 2023
(cherry picked from commit e0c63b7) Co-authored-by: gaogaotiantian <gaogaotiantian@hotmail.com>
miss-islington
added a commit
that referenced
this pull request
Mar 22, 2023
(cherry picked from commit e0c63b7) Co-authored-by: gaogaotiantian <gaogaotiantian@hotmail.com>
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change on pdb docs. The doc use to give an alias example below:
However, using this alias, there will be a space between the object name and the attribute like
self. attr = 1
, which is not how we are used to. By using f-strings(which is supported on all live python versions), we can make the alias doself.attr = 1