-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-32972: Add unittest.AsyncioTestCase #10296
Closed
dave-shawley
wants to merge
12
commits into
python:master
from
dave-shawley:bpo-32971-async-test-runner
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
564ada6
unittest.TestRunner: introduce _runTest method.
dave-shawley 9a780c6
unittest: Refactor TestCase.debug.
dave-shawley 60d3514
Add unittest.AsyncioTestCase.
dave-shawley 6fa2911
unittest: Introduce asyncSetUp/TearDown.
dave-shawley 231aab5
unittest: Introduce TestCase._terminateTest.
dave-shawley 88a697c
unittest: Shutdown async generators.
dave-shawley 9f6263e
unittest: Enable event loop debug flag.
dave-shawley 694e6d5
bpo-32972: Switch to "newer style" classes.
dave-shawley adb4c96
bpo-32972: Docstring cleanup in unittest.case.
dave-shawley 3c0ac43
bpo-32972: Rename AsyncioTestCase.event_loop.
dave-shawley 7eb7899
bpo-32972: Add NEWS blurb.
dave-shawley eed94cf
Merge branch 'master' into bpo-32971-async-test-runner
dave-shawley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the test case have to modify the global state like this? It is calling
self.loop.run_until_complete
when running things.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it does. This is the only way to ensure that the code under test gets the correct loop.