gh-101100: Test only Doc/ files in nit-picky mode #103019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #102513.
To fix #102513 (comment).
The problem is that the https://github.com/Ana06/get-changed-files action gives an error if there's a filename with a space, for example, a news file such as
Misc/NEWS.d/next/Core and Builtins/2023-03-17-12-09-45.gh-issue-100982.Pf_BI6.rst
.The error suggests using another format:
We can get in CSV or JSON format instead:
But that would require some refactoring, as we need to
touch
the list of files.The quick fix is to filter for files in the
Doc/
directory, to only consider those:It would of course be good to check the NEWS files, but it's less urgent than fixing the CI and unblocking other PRs!
Demo
hugovk#45 is a PR that modifies a
Doc/
file plus aMisc/NEWS.d/next/Core and Builtins/
file, and the "Docs / Docs" CI check fails, as expected.hugovk#44 is the same but also has this change, and "Docs / Docs" passes.