Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 1, 2023

Are there any others that I've missed?

@encukou
Copy link
Member

encukou commented Apr 3, 2023

LGTM. I've grepped all of these to check they're only called with no arguments.
But since this touches platform-specific code, let's ask the buildbots before merging.

Are there any others that I've missed?

If there are they can always go in a different PR.

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 3, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit eae4660 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 3, 2023
@sobolevn
Copy link
Member Author

sobolevn commented Apr 4, 2023

@encukou done! 👍

@encukou encukou merged commit 119f67d into python:main Apr 5, 2023
gaogaotiantian pushed a commit to gaogaotiantian/cpython that referenced this pull request Apr 8, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants