Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-103171: Document and test behaviour change in 3.11 for runtime-checkable protocols decorated with @final #103173

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Apr 1, 2023

@AlexWaygood AlexWaygood changed the title gh-103171: Document behaviour change in 3.11 for runtime-checkable protocols decorated with @final gh-103171: Document and test behaviour change in 3.11 for runtime-checkable protocols decorated with @final Apr 1, 2023
@AlexWaygood AlexWaygood marked this pull request as ready for review April 1, 2023 16:00
@AlexWaygood AlexWaygood added tests Tests in the Lib/test dir DO-NOT-MERGE labels Apr 1, 2023
@AlexWaygood
Copy link
Member Author

Marking as DO-NOT-MERGE until discussion on the issue has finished: #103171 (comment)

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to instead change the behavior, see the issue.

(Also I want this to go out of my review requested list.)

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@AlexWaygood
Copy link
Member Author

I'd like to instead change the behavior, see the issue.

In that case I'll close this PR for now, since the better approach will probably be to fix the behavior in a PR to the 3.11 branch, and then "forward-port" the tests from that PR to main/3.12. And I won't be able to change the target branch on this PR without pinging all core developers past, present and future

@AlexWaygood AlexWaygood closed this Jun 7, 2023
@AlexWaygood AlexWaygood deleted the document-runtimecheckable-final-change branch June 7, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes DO-NOT-MERGE docs Documentation in the Doc dir needs backport to 3.11 only security fixes skip news tests Tests in the Lib/test dir topic-typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants