-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-75586: Fix case where PATHEXT isn't applied to items in PATH (Windows) #103179
Conversation
@eryksun I think i fixed everything. Check again. Thanks! |
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@zooba updated and added a corresponding test. |
Looks good, and the tests all patch the call to that API so we shouldn't be impacted if the test machine has it configured differently. Once CI passes, and unless someone else speaks up, I'll merge. Thanks for all your work on this! |
Got a doctest failure... The error is odd.. maybe its transient? I'll push an empty commit to see if it helps.
|
@eryksun added. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you, Charles.
This change introduced a regression: #127001. |
GH-75586 - Fix case where PATHEXT isn't applied to items in PATH.
The logic change here makes it so that if the command passed into
shutil.which
on windows, it will be verified against how it is passed in and against the various items in PATHEXT.For example:
will now return
Instead of
None
.If this looks good, I'd be happy to create a changelog entry, etc. Just feeling the water with this first commit.