Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending #103463

Merged
merged 7 commits into from
Apr 13, 2023

Commits on Apr 12, 2023

  1. Add explicit tests for writelines

    Includes two failing tests that demonstrate a bug
    where if the data passed to writelines can't be sent
    in one shot, the remaining buffer isn't written since
    there is no registered write handler
    alisaifee committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    273e1e7 View commit details
    Browse the repository at this point in the history
  2. Schedule writer for remaining buffer in writelines

    If all the data in the buffer can't be written immediately
    schedule a writer to handle the remaining data.
    alisaifee committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    ce03f17 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8d2d34c View commit details
    Browse the repository at this point in the history
  4. Ensure tests using sendmsg are marked with skip

    When the platform (windows) doesn't support it
    skip tests for writelines using sendmsg
    alisaifee committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c5a071e View commit details
    Browse the repository at this point in the history
  5. Add NEWS entry

    alisaifee committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    7f2b1e7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d2bdce2 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Configuration menu
    Copy the full SHA
    239a80f View commit details
    Browse the repository at this point in the history