Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103479: [Enum] require __new__ to be considered a data type #103495

Merged
merged 1 commit into from
Apr 13, 2023
Merged

gh-103479: [Enum] require __new__ to be considered a data type #103495

merged 1 commit into from
Apr 13, 2023

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Apr 13, 2023 •
edited by bedevere-bot
Loading

@ethanfurman ethanfurman added tests Tests in the Lib/test dir skip news stdlib Python modules in the Lib dir 3.11 only security fixes 3.12 bugs and security fixes needs backport to 3.11 only security fixes labels Apr 13, 2023
@ethanfurman ethanfurman self-assigned this Apr 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 13, 2023
Closed
@ethanfurman ethanfurman merged commit a6f9594 into python:main Apr 13, 2023
@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @ethanfurman, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a6f95941a3d686707fb38e0f37758e666f25e180 3.11

@ethanfurman ethanfurman deleted the enum-init_not_new branch April 13, 2023 15:32
@bedevere-bot
Copy link

GH-103514 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 13, 2023
ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Apr 13, 2023
@ethanfurman
[3.11] pythongh-103479: [Enum] require __new__ to be considered a da…
ab60fdd 
…ta type (pythonGH-103495)

a mixin must either have a __new__ method, or be a dataclass, to be interpreted as a data-type.
                    (cherry picked from commit a6f9594)

                    Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
carljm added a commit to carljm/cpython that referenced this pull request Apr 13, 2023
@carljm
Merge branch 'main' into superopt
9384106 
* main:
  pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495)
  pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494)
  pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502)
  pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500)
  pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507)
  pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228)
  pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463)
  pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
ethanfurman added a commit that referenced this pull request Apr 13, 2023
@ethanfurman
[3.11] gh-103479: [Enum] require __new__ to be considered a data type (…
3b929a7 
…GH-103495) (GH-103514)

a mixin must either have a __new__ method, or be a dataclass, to be interpreted as a data-type; an __init__ method is not enough (restores pre-3.11 behavior for non-dataclasses).

(cherry picked from commit a6f9594)
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ethanfurman ethanfurman

Labels
3.11 only security fixes 3.12 bugs and security fixes skip news stdlib Python modules in the Lib dir tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethanfurman @miss-islington @bedevere-bot