Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103596: [Enum] do not shadow mixed-in methods/attributes #103600

Merged
merged 2 commits into from
Apr 18, 2023
Merged

gh-103596: [Enum] do not shadow mixed-in methods/attributes #103600

merged 2 commits into from
Apr 18, 2023

Commits on Apr 17, 2023

  1. do not shadow mixed-in methods/attributes 

    For example:

    class Book(StrEnum):
        title = auto()
        author = auto()
        desc = auto()

    Book.author.desc is Book.desc

but

    Book.author.title() == 'Author'

Using upper-case member names means this isn't an issue in practice.
    @ethanfurman
    ethanfurman committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b1b5392 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. fix typo 

    Co-authored-by: samypr100 <3933065+samypr100@users.noreply.github.com>
    @ethanfurman @samypr100
    ethanfurman and samypr100 authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    0d06493 View commit details
    Browse the repository at this point in the history