-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-103793: Defer formatting task name #103767
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e8353cc
Defer formatting task name
itamaro 1822ff8
Defer task name formatting also in Python Task impl
itamaro 74d0084
Add NEWS and whatsnew entries
itamaro dbc7047
Merge branch 'main' into defer-task-name-formatting
ambv 2bb6c1e
Merge branch 'main' into defer-task-name-formatting
itamaro 2efd376
replace storing the task counter on task construction with just getti…
itamaro 6cb321b
Merge branch 'defer-task-name-formatting' of github.com:itamaro/cpyth…
itamaro 7cde290
remove redundant return
itamaro 4b50646
Merge branch 'main' into defer-task-name-formatting
itamaro a155190
revert changes to python version
itamaro fb2bd7f
pass error up if PyUnicode_FromFormat returns NULL
itamaro 41e9a59
Switch back to original "assign task number at construction" but stor…
itamaro 712edf9
Add test that using an explicit PyLong as task name does not accident…
itamaro 592d44b
Merge branch 'main' into defer-task-name-formatting
itamaro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Core and Builtins/2023-04-24-14-38-16.gh-issue-103793.kqoH6Q.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Optimized asyncio Task creation by deferring expensive string formatting | ||
(task name generation) from Task creation to the first time ``get_name`` is | ||
called. This makes asyncio benchmarks up to 5% faster. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to optimize the .py version (which is normally not run since there is a C accelerator version)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we definitely don't need to optimize the python version. I assumed we wanted to maintain parity between the versions, but maybe it doesn't matter to this extent (or my assumption was wrong and parity is not a goal).
I will revert the changes to the python version.