gh-103092: Adapt _ctypes's PyCStgDict type to heap type #103932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
|
This probably fails because of the dict hacks in |
Port PyCStgDict_Type to heap type.
kumaraditya303
force-pushed
the
isolate-ctypes/part2-take2
branch
from
11c91c9
to
56fd7e9
Compare
|
While I am still trying to figure out where it breaks, you may proceed to port other simpler types (if there are any). |
|
What's the status of this PR? Is it ready for review? It's still marked as a draft. |
neonene
reviewed
Jan 4, 2024
| PyCStgDict_traverse(StgDictObject *self, visitproc visit, void *arg) | ||
| { | ||
| Py_VISIT(Py_TYPE(self)); | ||
| Py_VISIT(self->proto); |
There was a problem hiding this comment.
Maybe an extra visit to the proto member? The CDataType_traverse function in _ctypes.c has an explicit Py_VISIT(dict->proto).
erlend-aasland
changed the title
erlend-aasland
changed the title
|
I don't have the bandwidth to follow up this right now; abandoning this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port PyCStgDict_Type to heap type.