Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-97850: Suppress cross-references to the removed module_repr method #104133

Merged
merged 1 commit into from
May 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Doc/reference/import.rst
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ Here are the exact rules used:
* Otherwise, just use the module's ``__name__`` in the repr.

.. versionchanged:: 3.12
Use of :meth:`module_repr`, having been deprecated since Python 3.4, was
Use of :meth:`!module_repr`, having been deprecated since Python 3.4, was
removed in Python 3.12 and is no longer called during the resolution of a
module's repr.

Expand Down
10 changes: 5 additions & 5 deletions Doc/whatsnew/3.10.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1612,7 +1612,7 @@ Deprecated
(superseded by :meth:`~importlib.abc.Finder.find_spec`),
:meth:`~importlib.abc.Loader.load_module`
(superseded by :meth:`~importlib.abc.Loader.exec_module`),
:meth:`~importlib.abc.Loader.module_repr` (which the import system
:meth:`!module_repr` (which the import system
takes care of for you), the ``__package__`` attribute
(superseded by ``__spec__.parent``), the ``__loader__`` attribute
(superseded by ``__spec__.loader``), and the ``__cached__`` attribute
Expand Down Expand Up @@ -1693,14 +1693,14 @@ Deprecated
(Contributed by Brett Cannon in :issue:`43720`.)

* The import system now uses the ``__spec__`` attribute on modules before
falling back on :meth:`~importlib.abc.Loader.module_repr` for a module's
falling back on :meth:`!module_repr` for a module's
``__repr__()`` method. Removal of the use of ``module_repr()`` is scheduled
for Python 3.12.
(Contributed by Brett Cannon in :issue:`42137`.)

* :meth:`importlib.abc.Loader.module_repr`,
:meth:`importlib.machinery.FrozenLoader.module_repr`, and
:meth:`importlib.machinery.BuiltinLoader.module_repr` are deprecated and
* :meth:`!importlib.abc.Loader.module_repr`,
:meth:`!importlib.machinery.FrozenLoader.module_repr`, and
:meth:`!importlib.machinery.BuiltinLoader.module_repr` are deprecated and
slated for removal in Python 3.12.
(Contributed by Brett Cannon in :issue:`42136`.)

Expand Down
2 changes: 1 addition & 1 deletion Doc/whatsnew/3.11.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1877,7 +1877,7 @@ C APIs pending removal are
* The :class:`typing.re <typing.Pattern>` namespace
* :func:`!cgi.log`
* :func:`!importlib.find_loader`
* :meth:`importlib.abc.Loader.module_repr`
* :meth:`!importlib.abc.Loader.module_repr`
* :meth:`!importlib.abc.MetaPathFinder.find_module`
* :meth:`!importlib.abc.PathEntryFinder.find_loader`
* :meth:`!importlib.abc.PathEntryFinder.find_module`
Expand Down
2 changes: 1 addition & 1 deletion Doc/whatsnew/3.12.rst
Original file line number Diff line number Diff line change
Expand Up @@ -983,7 +983,7 @@ Removed
* Many previously deprecated cleanups in :mod:`importlib` have now been
completed:

* References to, and support for ``module_repr()`` has been removed.
* References to, and support for :meth:`!module_repr()` has been removed.
(Contributed by Barry Warsaw in :gh:`97850`.)

* ``importlib.util.set_package`` has been removed. (Contributed by Brett
Expand Down
2 changes: 1 addition & 1 deletion Doc/whatsnew/3.4.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2096,7 +2096,7 @@ Deprecations in the Python API
:meth:`importlib.abc.InspectLoader.exec_module`
:meth:`importlib.abc.SourceLoader.exec_module`) and let the import system
take care of the rest; and
:meth:`importlib.abc.Loader.module_repr`,
:meth:`!importlib.abc.Loader.module_repr`,
:meth:`importlib.util.module_for_loader`, :meth:`importlib.util.set_loader`,
and :meth:`importlib.util.set_package` are no longer needed because their
functions are now handled automatically by the import system.
Expand Down