gh-104360: remove reference to removed module-level wrap_socket #104361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
May 10, 2023
eamanu
reviewed
May 10, 2023
| @@ -2453,12 +2453,8 @@ provided. | |||
| :exc:`SSLWantReadError` if it needs more data than the incoming BIO has | |||
| available. | |||
|
|
|||
| - There is no module-level ``wrap_bio()`` call like there is for | |||
There was a problem hiding this comment.
ssl.wrap_context() is removed, but ssl.SSLContext.wrap_socket does not.
There was a problem hiding this comment.
@eamanu right but there is no module-level wrap_socket so this section doesn't make sense anymore
eamanu
approved these changes
Jun 17, 2023
AA-Turner
added
needs backport to 3.11
|
Thanks @graingert for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 24, 2024
…pythonGH-104361) * remove reference to removed module-level wrap_socket * drive by typo fix (cherry picked from commit 127a497) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 24, 2024
…pythonGH-104361) * remove reference to removed module-level wrap_socket * drive by typo fix (cherry picked from commit 127a497) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
|
GH-114528 is a backport of this pull request to the 3.12 branch. |
|
GH-114529 is a backport of this pull request to the 3.11 branch. |
encukou
pushed a commit
that referenced
this pull request
Jan 24, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…pythonGH-104361) * remove reference to removed module-level wrap_socket * drive by typo fix
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…pythonGH-104361) * remove reference to removed module-level wrap_socket * drive by typo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--104361.org.readthedocs.build/