-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-86275: improve Hypothesis configuration for CI and local runs #104468
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,35 @@ | ||
import os | ||
|
||
try: | ||
import hypothesis | ||
except ImportError: | ||
from . import _hypothesis_stubs as hypothesis | ||
else: | ||
# When using the real Hypothesis, we'll configure it to ignore occasional | ||
# slow tests (avoiding flakiness from random VM slowness in CI). | ||
hypothesis.settings.register_profile( | ||
"slow-is-ok", | ||
deadline=None, | ||
suppress_health_check=[hypothesis.HealthCheck.too_slow], | ||
) | ||
hypothesis.settings.load_profile("slow-is-ok") | ||
|
||
# For local development, we'll write to the default on-local-disk database | ||
# of failing examples, and also use a pull-through cache to automatically | ||
# replay any failing examples discovered in CI. For details on how this | ||
# works, see https://hypothesis.readthedocs.io/en/latest/database.html | ||
if "CI" not in os.environ: | ||
from hypothesis.database import ( | ||
GitHubArtifactDatabase, | ||
MultiplexedDatabase, | ||
ReadOnlyDatabase, | ||
) | ||
|
||
hypothesis.settings.register_profile( | ||
"cpython-local-dev", | ||
database=MultiplexedDatabase( | ||
hypothesis.settings.default.database, | ||
ReadOnlyDatabase(GitHubArtifactDatabase("python", "cpython")), | ||
), | ||
) | ||
hypothesis.settings.load_profile("cpython-local-dev") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zac-HD did you mean to keep that leading hyphen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it look up the
'- hypothesis-database-'
prefix, and I'm pretty sure you wanted'hypothesis-database-'
:Cache not found for input keys: hypothesis-database-9927179210, - hypothesis-database-
(https://github.com/python/cpython/actions/runs/9927179210/job/27421821417#step:21:24)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zac-HD here's the fix: #121756