-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-75367: fix data descriptor detection in inspect.getattr_static #104517
Conversation
furkanonder
commented
May 15, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Fix data descriptor detection in inspect.getattr_static #75367
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Code change LGTM. Test can be simplified, I think. Please add NEWS entry.
Co-authored-by: Carl Meyer <carl@oddbird.net>
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @furkanonder!
Thanks @furkanonder for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-104557 is a backport of this pull request to the 3.11 branch. |
|
|