gh-104341: Clean Up threading Module #104552
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix gh-104341, we need to change the threading module to utilize two locks for each thread: one for if it running (for
join()
) and one for its overall lifetime, on whichPy_EndInterpreter()
will wait. This PR cleans things up to make it easier to make that change. As part of that, we move all the module's state out ofPyThreadState
andPyInterpreterState
.