Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104340: Suppress warning about unawaited exception for closed pipe stdin #104586

Merged
merged 2 commits into from
May 17, 2023
Merged

gh-104340: Suppress warning about unawaited exception for closed pipe stdin #104586

merged 2 commits into from
May 17, 2023

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented May 17, 2023 •
edited by bedevere-bot
Loading

According to my analysis in the issue, the warning is more annoying/distracting than useful, and since the docs for StreamWriter.close() say that calling wait_closed() is optional, we shouldn't penalize users for not waiting if there was an error (e.g. BrokenPipeError in drain()).

@bedevere-bot bedevere-bot mentioned this pull request May 17, 2023
Closed
@gvanrossum gvanrossum added 3.12 bugs and security fixes needs backport to 3.11 only security fixes and removed 3.12 bugs and security fixes labels May 17, 2023
willingc
willingc approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvanrossum
Copy link
Member Author

Waiting for @kumaraditya303, but I'd like to get this in 3.12, since it's so minor.

@kumaraditya303
Copy link
Contributor

LGTM

@gvanrossum gvanrossum merged commit 7fc8e2d into python:main May 17, 2023
@miss-islington
Copy link
Contributor

Thanks @gvanrossum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@gvanrossum gvanrossum deleted the wait-closed-fix branch May 17, 2023 23:45
@bedevere-bot
Copy link

GH-104594 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 17, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 17, 2023
@gvanrossum @miss-islington
pythongh-104340: Suppress warning about unawaited exception for close…
51a688f 
…d pipe stdin (pythonGH-104586)

(cherry picked from commit 7fc8e2d)

Co-authored-by: Guido van Rossum <guido@python.org>
gvanrossum added a commit that referenced this pull request May 18, 2023
@miss-islington @gvanrossum
[3.11] gh-104340: Suppress warning about unawaited exception for clos…
a8fc8b7 
…ed pipe stdin (GH-104586) (#104594)

(cherry picked from commit 7fc8e2d)

Co-authored-by: Guido van Rossum <guido@python.org>
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request May 18, 2023
@gvanrossum @JelleZijlstra
pythongh-104340: Suppress warning about unawaited exception for close…
9fd1d40 
…d pipe stdin (python#104586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gvanrossum @kumaraditya303 @miss-islington @bedevere-bot @willingc