GH-101291: Avoid using macros with casts in low-level long API. #104742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwgk can you confirm that this fixes the pybind11 compilation issue? |
Yes, confirmed! Thanks for the quick fix! Building all pybind11 unit tests works again. For completeness: I'm currently unable to run the full suite of pybind11 unit tests b/o an unrelated problem (#103912 (comment)). |
iritkatriel
approved these changes
May 22, 2023
|
Thanks @markshannon for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2023
…pythonGH-104742) (cherry picked from commit e295d86) Co-authored-by: Mark Shannon <mark@hotpy.org>
|
GH-104759 is a backport of this pull request to the 3.12 branch. |
|
(Backporting since this fixes compiler warnings from a recent change, so this counts as a bug fix.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stick to inline functions and plain
assertto avoid losingconstness.Fixes C++ compiler warnings.
See #101685 (comment)