Skip to content

gh-102251: Fix reference leak in _testsinglephase initialization #105082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2023
Merged

gh-102251: Fix reference leak in _testsinglephase initialization #105082

merged 2 commits into from
May 30, 2023

Conversation

sunmy2019
Copy link
Member

@sunmy2019 sunmy2019 commented May 30, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 30, 2023
Closed
erlend-aasland
erlend-aasland reviewed May 30, 2023
View reviewed changes
@sunmy2019 sunmy2019 mentioned this pull request May 30, 2023
Closed
@erlend-aasland erlend-aasland self-assigned this May 30, 2023
@erlend-aasland erlend-aasland added the needs backport to 3.12 only security fixes label May 30, 2023
@erlend-aasland erlend-aasland enabled auto-merge (squash) May 30, 2023 09:05
@erlend-aasland erlend-aasland changed the title gh-102251: add missing decref in testsinglephase gh-102251: Fix reference leak in _testsinglephase initialization May 30, 2023
@erlend-aasland
Copy link
Contributor

Thanks

@erlend-aasland erlend-aasland merged commit d14eb34 into python:main May 30, 2023
@miss-islington
Copy link
Contributor

Thanks @sunmy2019 for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-105083 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 30, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2023
@sunmy2019 @erlend-aasland @miss-islington
pythongh-102251: Fix reference leak in _testsinglephase initialization (
7924bd6 
pythonGH-105082)

Correctly decref 'initialized' in init_module()

(cherry picked from commit d14eb34)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@sunmy2019 sunmy2019 deleted the gh-102251-1 branch May 30, 2023 09:36
erlend-aasland added a commit that referenced this pull request May 30, 2023
@miss-islington @sunmy2019 @erlend-aasland
[3.12] gh-102251: Fix reference leak in _testsinglephase initializati…
fd6b913 
…on (GH-105082) (#105083)

Correctly decref 'initialized' in init_module()

(cherry picked from commit d14eb34)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

@erlend-aasland erlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sunmy2019 @erlend-aasland @miss-islington @bedevere-bot