Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.12] gh-104614: Make Sure ob_type is Always Set Correctly by PyType_Ready() (gh-105122) #105211

Merged
merged 1 commit into from
Jun 1, 2023
Merged

[3.12] gh-104614: Make Sure ob_type is Always Set Correctly by PyType_Ready() (gh-105122) #105211

merged 1 commit into from
Jun 1, 2023

Commits on Jun 1, 2023

  1. pythongh-104614: Make Sure ob_type is Always Set Correctly by PyType_… 

    …Ready() (pythongh-105122)

When I added the relevant condition to type_ready_set_bases() in pythongh-103912, I had missed that the function also sets tp_base and ob_type (if necessary).  That led to problems for third-party static types.

We fix that here, by making those extra operations distinct and by adjusting the condition to be more specific.
(cherry picked from commit 1469393)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
    @ericsnowcurrently @miss-islington
    ericsnowcurrently authored and miss-islington committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    d374433 View commit details
    Browse the repository at this point in the history