Skip to content

Conversation

sunmy2019
Copy link
Member

@sunmy2019 sunmy2019 commented Jun 5, 2023

Personally, I am not satisfied with the test case added in test_support.py, but I can not figure out something better.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sunmy2019
Copy link
Member Author

I have made the requested changes; please review again

I think we need news for this one, right?

@bedevere-bot
Copy link

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

@erlend-aasland
Copy link
Contributor

I think we need news for this one, right?

Well, test changes rarely get their own NEWS items. Personally, I would not bother with it. Related: also note that a lot of the test.support methods intentionally lack docs.

@sunmy2019
Copy link
Member Author

Closed. See #104796 (comment)

@sunmy2019 sunmy2019 closed this Jun 20, 2023
@sunmy2019 sunmy2019 deleted the gh-105310 branch June 23, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants