-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-104635: Eliminate redundant STORE_FAST instructions in the compiler #105320
Conversation
Mark's change + dead_store elimination + apply_static_swaps makes 3-5% faster without adding super instruction. |
('STORE_FAST', 1, 4), | ||
('POP_TOP', 0, 4), | ||
('RETURN_VALUE', 5) | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 instructions -> 5 instructions
('POP_TOP', 0, 4), | ||
('STORE_FAST', 1, 4), | ||
('RETURN_VALUE', 5) | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 instructions -> 5 instructions
@carljm Can you please take a look at? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Benchmarks