Skip to content

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jun 6, 2023

@AlexWaygood
Copy link
Member Author

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for Jelle.

@AlexWaygood AlexWaygood closed this Jun 7, 2023
@AlexWaygood AlexWaygood reopened this Jun 7, 2023
@AlexWaygood AlexWaygood requested a review from JelleZijlstra June 7, 2023 16:31
@AlexWaygood AlexWaygood closed this Jun 7, 2023
@AlexWaygood AlexWaygood reopened this Jun 7, 2023
@AlexWaygood AlexWaygood enabled auto-merge (squash) June 7, 2023 17:14
@AlexWaygood AlexWaygood disabled auto-merge June 7, 2023 17:15
@AlexWaygood AlexWaygood merged commit fbdee00 into python:main Jun 7, 2023
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-105460 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 7, 2023
@bedevere-bot
Copy link

GH-105461 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2023
…eferences (pythonGH-105366)

(cherry picked from commit fbdee00)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2023
…eferences (pythonGH-105366)

(cherry picked from commit fbdee00)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Jun 7, 2023
…references (GH-105366) (#105461)

gh-90015: Document that PEP-604 unions do not support forward references (GH-105366)
(cherry picked from commit fbdee00)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Jun 7, 2023
…references (GH-105366) (#105460)

gh-90015: Document that PEP-604 unions do not support forward references (GH-105366)
(cherry picked from commit fbdee00)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news topic-typing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants