Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103171: Forward-port new tests for runtime-checkable protocols decorated with @final #105473

Merged
merged 1 commit into from
Jun 7, 2023
Merged

gh-103171: Forward-port new tests for runtime-checkable protocols decorated with @final #105473

merged 1 commit into from
Jun 7, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jun 7, 2023 •
edited by bedevere-bot
Loading

@AlexWaygood
pythongh-103171: Forward-port new tests for runtime-checkable protoco…
e96c2e8 
…ls decorated with `@final`

Forward-port of the tests that were added to the 3.11 branch in python#105445
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 7, 2023
Closed
@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label Jun 7, 2023
@AlexWaygood AlexWaygood enabled auto-merge (squash) June 7, 2023 22:19
@AlexWaygood AlexWaygood changed the title gh-103171: Forward-port new tests for runtime-checkable protocols dec orated with @final gh-103171: Forward-port new tests for runtime-checkable protocols decorated with @final Jun 7, 2023
@AlexWaygood AlexWaygood merged commit f5df347 into python:main Jun 7, 2023
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105474 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2023
@AlexWaygood @miss-islington
pythongh-103171: Forward-port new tests for runtime-checkable protoco…
0e124fc 
…ls dec orated with `@final` (pythonGH-105473)

Forward-port of the tests that were added to the 3.11 branch in pythonGH-105445
(cherry picked from commit f5df347)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood AlexWaygood deleted the Finalprotocol branch June 7, 2023 22:26
@bedevere-bot
Copy link

GH-105474 is a backport of this pull request to the 3.12 branch.

AlexWaygood added a commit that referenced this pull request Jun 7, 2023
@miss-islington @AlexWaygood
[3.12] gh-103171: Forward-port new tests for runtime-checkable protoc…
4b2263e 
…ols decorated with `@final` (GH-105473) (#105474)

Forward-port of the tests that were added to the 3.11 branch in GH-105445
(cherry picked from commit f5df347)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra