Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105375: Improve error handling in PyUnicode_BuildEncodingMap() #105491

Merged
merged 3 commits into from
Jun 11, 2023
Merged

gh-105375: Improve error handling in PyUnicode_BuildEncodingMap() #105491

merged 3 commits into from
Jun 11, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 8, 2023 •
edited
Loading

@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jun 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 8, 2023
Closed
18 tasks
@erlend-aasland erlend-aasland requested a review from vstinner June 8, 2023 12:23
@erlend-aasland erlend-aasland merged commit 555be81 into python:main Jun 11, 2023
@erlend-aasland erlend-aasland deleted the improve-unicodeobject-error-handling branch June 11, 2023 19:29
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve error handling in PyUnicode_BuildEncodingMap…
6ac9a8b 
…() (pythonGH-105491)

Bail on first error to prevent exceptions from possibly being overwritten.
(cherry picked from commit 555be81)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve error handling in PyUnicode_BuildEncodingMap…
c826c47 
…() (pythonGH-105491)

Bail on first error to prevent exceptions from possibly being overwritten.
(cherry picked from commit 555be81)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105661 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 11, 2023
@bedevere-bot
Copy link

GH-105662 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 11, 2023
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington @erlend-aasland
[3.12] gh-105375: Improve error handling in PyUnicode_BuildEncodingMa…
ed03895 
…p() (GH-105491) (#105661)

Bail on first error to prevent exceptions from possibly being overwritten.
(cherry picked from commit 555be81)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington @erlend-aasland
[3.11] gh-105375: Improve error handling in PyUnicode_BuildEncodingMa…
9187747 
…p() (GH-105491) (#105662)

Bail on first error to prevent exceptions from possibly being overwritten.
(cherry picked from commit 555be81)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @miss-islington @bedevere-bot