Skip to content

Docs fix-up: Remove references to ProcessPoolExecutor from asyncio-dev.rst #105543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eirrgang
Copy link
Contributor

@eirrgang eirrgang commented Jun 9, 2023

ddd5f36 updated asyncio-eventloop.rst, but overlooked other references to using non-ThreadPoolExecutors with run_in_executor().

Ref bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor (GH-24540)


📚 Documentation preview 📚: https://cpython-previews--105543.org.readthedocs.build/

ddd5f36 updated asyncio-eventloop.rst, but overlooked other references to using non-ThreadPoolExecutors with `run_in_executor()`.

Ref bpo-43234: Prohibit non-ThreadPoolExecutor in loop.set_default_executor (pythonGH-24540)
@eirrgang
Copy link
Contributor Author

eirrgang commented Jun 9, 2023

I think I may have misinterpreted the update and the documentation. It looks like it is only set_default_executor for which ProcessPoolExecutor has been disallowed. A ProcessPoolExecutor instance can still be passed to run_in_executor() as an argument.

@eirrgang eirrgang closed this Jun 9, 2023
@eirrgang eirrgang deleted the patch-1 branch June 14, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants