Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-105375: Improve posix error handling #105592

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 9, 2023

Fix a bug where an IndexError could be overwritten.

Fix a bug where an IndexError could be overwritten.
@erlend-aasland
Copy link
Contributor Author

I'm considering this a straight-forward, non-controversial change. Merging, since the CI is green.

@erlend-aasland erlend-aasland merged commit f668f73 into python:main Jun 9, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the improve-posix-error-handling branch June 9, 2023 20:07
@miss-islington
Copy link
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker f668f73bc88cce0112b304d87aa998fb28013c71 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2023
Fix a bug where an IndexError could end up being overwritten.
(cherry picked from commit f668f73)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105597 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 9, 2023
@erlend-aasland erlend-aasland linked an issue Jun 9, 2023 that may be closed by this pull request
18 tasks
@erlend-aasland erlend-aasland added needs backport to 3.12 bug and security fixes and removed needs backport to 3.12 bug and security fixes labels Jun 9, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2023
Fix a bug where an IndexError could end up being overwritten.
(cherry picked from commit f668f73)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105598 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 9, 2023
erlend-aasland added a commit that referenced this pull request Jun 9, 2023
Fix a bug where an IndexError could end up being overwritten.
(cherry picked from commit f668f73)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
Fix a bug where an IndexError could end up being overwritten.
(cherry picked from commit f668f73)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error handling for APIs that can raise exceptions
3 participants