Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bpo-35266: Add _PyPreConfig #10575

Closed
wants to merge 3 commits into from
Closed

[WIP] bpo-35266: Add _PyPreConfig #10575

wants to merge 3 commits into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 16, 2018

  • Remove PyInterpreterState.core_config: _PyMainInterpreterConfig now
    has a "_PyCoreConfig core_config" attribute.
  • Add _PyPreConfig structure which contains a _PyCoreConfig attriute
  • Move program_name, program and pycache_prefix from _PyCoreConfig
    into _PyPreConfig
  • Add program_name and program to _PyMainInterpreterConfig
  • Py_Main() now uses a _PyPreConfig for early Python intiailization
  • _PyPreConfig is destroyed when Python initialization is done

https://bugs.python.org/issue35266

* Remove PyInterpreterState.core_config: _PyMainInterpreterConfig now
  has a "_PyCoreConfig core_config" attribute.
* Add _PyPreConfig structure which contains a _PyCoreConfig attriute
* Move program_name, program and pycache_prefix from _PyCoreConfig
  into _PyPreConfig
* Add program_name and program to _PyMainInterpreterConfig
* Py_Main() now uses a _PyPreConfig for early Python intiailization
* _PyPreConfig is destroyed when Python initialization is done
@vstinner vstinner requested a review from a team November 16, 2018 14:44
@vstinner vstinner changed the title bpo-35266: Add _PyPreConfig [WIP] bpo-35266: Add _PyPreConfig Nov 16, 2018
@vstinner
Copy link
Member Author

When I looked again at this issue, I'm not sure how what should be done, what is the proper design, what should stay after Python initialization, etc. I prefer to abandon this change and maybe retry to write it later.

I have a more advanced version in this branch of my fork: https://github.com/vstinner/cpython/commits/pre_config_next

@vstinner vstinner closed this Dec 17, 2018
@vstinner vstinner deleted the pre_config branch December 17, 2018 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants