Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-105793: Add follow_symlinks argument to pathlib.Path.is_dir() and is_file() #105794

Merged
merged 7 commits into from
Jun 26, 2023

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Jun 14, 2023

Brings pathlib.Path.is_dir() in line with os.DirEntry.is_dir(), likewise is_file(), which will be important for implementing generic path walking and globbing.


📚 Documentation preview 📚: https://cpython-previews--105794.org.readthedocs.build/

Brings `pathlib.Path.is_dir()` in line with `os.DirEntry.is_dir()`, which
will be important for implementing generic path walking and globbing.
@barneygale barneygale changed the title GH-105793: Add follow_symlinks argument to pathlib.Path.is_dir() GH-105793: Add follow_symlinks argument to pathlib.Path.is_dir() and is_file() Jun 15, 2023
@barneygale
Copy link
Contributor Author

@zooba would you be up for reviewing this? It's similar to #102616, and necessary for a pathlib.AbstractPath or tarfile.TarPath to support globbing. Thank you, no worries if not!

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants