Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-105808: Fix a regression introduced in GH-101251 #105910

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Conversation

Yhg1s
Copy link
Member

@Yhg1s Yhg1s commented Jun 19, 2023

Fix a regression introduced in GH-101251, causing GzipFile.flush() to not flush the compressor (nor pass along the zip_mode argument).

…h() to

not flush the compressor (nor pass along the zip_mode argument).
@Yhg1s Yhg1s requested review from ambv and gpshead June 19, 2023 11:32
@gpshead gpshead added the needs backport to 3.12 bug and security fixes label Jun 19, 2023
@gpshead gpshead enabled auto-merge (squash) June 19, 2023 16:40
@gpshead gpshead merged commit 1858db7 into python:main Jun 19, 2023
@miss-islington
Copy link
Contributor

Thanks @Yhg1s for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105920 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2023
…onGH-105910)

Fix a regression introduced in pythonGH-101251, causing GzipFile.flush() to
not flush the compressor (nor pass along the zip_mode argument).
(cherry picked from commit 1858db7)

Co-authored-by: T. Wouters <thomas@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 19, 2023
Yhg1s added a commit that referenced this pull request Jun 19, 2023
#105920)

GH-105808: Fix a regression introduced in GH-101251 (GH-105910)

Fix a regression introduced in GH-101251, causing GzipFile.flush() to
not flush the compressor (nor pass along the zip_mode argument).
(cherry picked from commit 1858db7)

Co-authored-by: T. Wouters <thomas@python.org>
@Yhg1s Yhg1s deleted the gzip-flush branch November 22, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants