Skip to content

gh-106300: Improve assertRaises(Exception) usages in tests #106302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2023
Merged

gh-106300: Improve assertRaises(Exception) usages in tests #106302

merged 2 commits into from
Jul 7, 2023

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 1, 2023 •
edited by bedevere-bot
Loading

Things I did:

  1. I've used some real exceptions that is raised by stdlib code, where exception is known: zlib.error as an example
  2. I've added several CustomError definitions to be sure that we get what we expect in a custom raising code
  3. I've also specified error message with assertRaisesRegex where possible

Note that test_unittest will have its own PR due to bugs I found in #106300 (comment)

This PR does only change semantics, no bugs.

@bedevere-bot bedevere-bot mentioned this pull request Jul 1, 2023
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But we need to run tests on buildbots to ensure that the same exceptions are raised on all platforms.

There are also few assertRaises(BaseException). Could you add these cases too?

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jul 1, 2023

Of course, if these cases are not already excluded by your rules.

@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 1, 2023
@bedevere-bot
Copy link

bedevere-bot commented Jul 1, 2023

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 77b7f83 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 1, 2023
@sobolevn
Copy link
Member Author

sobolevn commented Jul 1, 2023

For me it would be easier to merge this one first, then I can work on BaseException cases later (I will be offline the next week or so).

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 1, 2023
@cjw296
Copy link
Contributor

cjw296 commented Jul 2, 2023

Changes in mock look fine to me, so removing myself as a reviewer. Thanks for the work! :-)

@cjw296 cjw296 removed their request for review July 2, 2023 11:27
@brettcannon brettcannon merged commit 6e6a4cd into python:main Jul 7, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jul 7, 2023

Thanks @sobolevn for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@brettcannon
Copy link
Member

brettcannon commented Jul 7, 2023

Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Jul 7, 2023

Sorry, @sobolevn and @brettcannon, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6e6a4cd52332017b10c8d88fbbbfe015948093f4 3.11

@bedevere-bot
Copy link

bedevere-bot commented Jul 7, 2023

GH-106534 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 7, 2023
@bedevere-bot
Copy link

bedevere-bot commented Jul 7, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit 6e6a4cd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/146/builds/5698) and take a look at the build logs.
  4. Check if the failure is related to this commit (6e6a4cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/146/builds/5698

Failed tests:

  • test_concurrent_futures

Summary of the results of the build (if available):

== Tests result: FAILURE then SUCCESS ==

415 tests OK.

10 slowest tests:

  • test_math: 5 min 2 sec
  • test_multiprocessing_spawn: 4 min 36 sec
  • test_wmi: 3 min 55 sec
  • test_peg_generator: 2 min 33 sec
  • test_capi: 2 min 25 sec
  • test_unparse: 2 min 25 sec
  • test_tokenize: 2 min 10 sec
  • test_compileall: 1 min 37 sec
  • test_unicodedata: 1 min 33 sec
  • test_mmap: 1 min 29 sec

31 tests skipped:
test.test_asyncio.test_unix_events test_curses test_dbm_gnu
test_dbm_ndbm test_devpoll test_epoll test_fcntl test_fork1
test_gdb test_grp test_ioctl test_kqueue test_multiprocessing_fork
test_multiprocessing_forkserver test_openpty test_perf_profiler
test_perfmaps test_poll test_posix test_pty test_pwd test_readline
test_resource test_syslog test_threadsignals test_wait3 test_wait4
test_xxlimited test_xxtestfuzz test_zipfile64 test_zoneinfo

1 re-run test:
test_concurrent_futures

Total duration: 28 min 14 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\__init__.py", line 207, in _force_run
    return func(*args)
           ^^^^^^^^^^^
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\buildarea\\3.x.bolen-windows10\\build\\build\\test_python_8500�\\test_python_worker_9812�'


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\__main__.py", line 2, in <module>
    main()
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 822, in main
    Regrtest().main(tests=tests, **kwargs)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 752, in main
    with os_helper.temp_cwd(test_cwd, quiet=True):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\contextlib.py", line 155, in __exit__
    self.gen.throw(value)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 531, in temp_cwd
    with temp_dir(path=name, quiet=quiet) as temp_path:
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\contextlib.py", line 155, in __exit__
    self.gen.throw(value)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 485, in temp_dir
    rmtree(path)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 442, in rmtree
    _rmtree(path)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 385, in _rmtree
    _waitfor(_rmtree_inner, path, waitall=True)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 330, in _waitfor
    func(pathname)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 382, in _rmtree_inner
    _force_run(fullname, os.rmdir, fullname)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\__init__.py", line 218, in _force_run
    return func(*args)
           ^^^^^^^^^^^
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\buildarea\\3.x.bolen-windows10\\build\\build\\test_python_8500�\\test_python_worker_9812�'


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 480, in temp_dir
    yield path
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 533, in temp_cwd
    yield cwd_dir
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 758, in main
    self._main(tests, kwargs)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 817, in _main
    sys.exit(0)
SystemExit: 0

brettcannon pushed a commit that referenced this pull request Jul 7, 2023
@miss-islington @sobolevn
[3.12] gh-106300: Improve assertRaises(Exception) usages in tests (G…
2ade2fc 
…H-106302) (GH-106534)

gh-106300: Improve `assertRaises(Exception)` usages in tests (GH-106302)
(cherry picked from commit 6e6a4cd)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

bedevere-bot commented Jul 7, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux TraceRefs 3.x has failed when building commit 6e6a4cd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/484/builds/3626) and take a look at the build logs.
  4. Check if the failure is related to this commit (6e6a4cd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/484/builds/3626

Failed tests:

  • test__xxsubinterpreters
  • test_capi

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 32, done.        
remote: Counting objects:   3% (1/31)        
remote: Counting objects:   6% (2/31)        
remote: Counting objects:   9% (3/31)        
remote: Counting objects:  12% (4/31)        
remote: Counting objects:  16% (5/31)        
remote: Counting objects:  19% (6/31)        
remote: Counting objects:  22% (7/31)        
remote: Counting objects:  25% (8/31)        
remote: Counting objects:  29% (9/31)        
remote: Counting objects:  32% (10/31)        
remote: Counting objects:  35% (11/31)        
remote: Counting objects:  38% (12/31)        
remote: Counting objects:  41% (13/31)        
remote: Counting objects:  45% (14/31)        
remote: Counting objects:  48% (15/31)        
remote: Counting objects:  51% (16/31)        
remote: Counting objects:  54% (17/31)        
remote: Counting objects:  58% (18/31)        
remote: Counting objects:  61% (19/31)        
remote: Counting objects:  64% (20/31)        
remote: Counting objects:  67% (21/31)        
remote: Counting objects:  70% (22/31)        
remote: Counting objects:  74% (23/31)        
remote: Counting objects:  77% (24/31)        
remote: Counting objects:  80% (25/31)        
remote: Counting objects:  83% (26/31)        
remote: Counting objects:  87% (27/31)        
remote: Counting objects:  90% (28/31)        
remote: Counting objects:  93% (29/31)        
remote: Counting objects:  96% (30/31)        
remote: Counting objects: 100% (31/31)        
remote: Counting objects: 100% (31/31), done.        
remote: Compressing objects:   6% (1/15)        
remote: Compressing objects:  13% (2/15)        
remote: Compressing objects:  20% (3/15)        
remote: Compressing objects:  26% (4/15)        
remote: Compressing objects:  33% (5/15)        
remote: Compressing objects:  40% (6/15)        
remote: Compressing objects:  46% (7/15)        
remote: Compressing objects:  53% (8/15)        
remote: Compressing objects:  60% (9/15)        
remote: Compressing objects:  66% (10/15)        
remote: Compressing objects:  73% (11/15)        
remote: Compressing objects:  80% (12/15)        
remote: Compressing objects:  86% (13/15)        
remote: Compressing objects:  93% (14/15)        
remote: Compressing objects: 100% (15/15)        
remote: Compressing objects: 100% (15/15), done.        
remote: Total 32 (delta 18), reused 22 (delta 16), pack-reused 1        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '6e6a4cd52332017b10c8d88fbbbfe015948093f4'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 6e6a4cd523 gh-106300: Improve `assertRaises(Exception)` usages in tests (GH-106302)
Switched to and reset branch 'main'

Objects/object.c:2198: _Py_ForgetReference: Assertion failed: invalid object chain
Enable tracemalloc to get the memory block allocation traceback

object address  : 0x7f890ccc2e40
object refcount : 0
object type     : 0x55e55b8d8300
object type name: builtin_function_or_method
object repr     : <refcnt 0 at 0x7f890ccc2e40>

Fatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailed
Python runtime state: initialized

Thread 0x00007f8914b626c0 (most recent call first):
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/test__xxsubinterpreters.py", line 37 in _run_output
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/test__xxsubinterpreters.py", line 424 in f
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/threading.py", line 989 in run
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/threading.py", line 1052 in _bootstrap_inner
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/threading.py", line 1009 in _bootstrap

Current thread 0x00007f89161ef740 (most recent call first):
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/threading.py", line 282 in __exit__
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/threading.py", line 631 in wait
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/threading.py", line 976 in start
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/test__xxsubinterpreters.py", line 432 in test_in_threaded_subinterpreter
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/unittest/case.py", line 589 in _callTestMethod
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/unittest/case.py", line 634 in run
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/unittest/case.py", line 690 in __call__
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/unittest/suite.py", line 122 in run
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/unittest/suite.py", line 84 in __call__
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/unittest/runner.py", line 240 in run
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/support/__init__.py", line 1115 in _run_suite
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/support/__init__.py", line 1241 in run_unittest
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/libregrtest/main.py", line 803 in _main
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/libregrtest/main.py", line 758 in main
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/libregrtest/main.py", line 822 in main
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/__main__.py", line 2 in <module>
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/runpy.py", line 88 in _run_code
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/runpy.py", line 198 in _run_module_as_main

Extension modules: _testcapi, _xxsubinterpreters (total: 2)
make: *** [Makefile:2010: buildbottest] Aborted (core dumped)

Cannot open file '/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/test-results.xml' for upload

@bedevere-bot
Copy link

bedevere-bot commented Jul 7, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux TraceRefs 3.12 has failed when building commit 2ade2fc.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1197/builds/118) and take a look at the build logs.
  4. Check if the failure is related to this commit (2ade2fc) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1197/builds/118

Failed tests:

  • test__xxsubinterpreters
  • test_capi

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 15, done.        
remote: Counting objects:   6% (1/15)        
remote: Counting objects:  13% (2/15)        
remote: Counting objects:  20% (3/15)        
remote: Counting objects:  26% (4/15)        
remote: Counting objects:  33% (5/15)        
remote: Counting objects:  40% (6/15)        
remote: Counting objects:  46% (7/15)        
remote: Counting objects:  53% (8/15)        
remote: Counting objects:  60% (9/15)        
remote: Counting objects:  66% (10/15)        
remote: Counting objects:  73% (11/15)        
remote: Counting objects:  80% (12/15)        
remote: Counting objects:  86% (13/15)        
remote: Counting objects:  93% (14/15)        
remote: Counting objects: 100% (15/15)        
remote: Counting objects: 100% (15/15), done.        
remote: Compressing objects:  14% (1/7)        
remote: Compressing objects:  28% (2/7)        
remote: Compressing objects:  42% (3/7)        
remote: Compressing objects:  57% (4/7)        
remote: Compressing objects:  71% (5/7)        
remote: Compressing objects:  85% (6/7)        
remote: Compressing objects: 100% (7/7)        
remote: Compressing objects: 100% (7/7), done.        
remote: Total 15 (delta 8), reused 13 (delta 8), pack-reused 0        
From https://github.com/python/cpython
 * branch                  3.12       -> FETCH_HEAD
Note: switching to '2ade2fc148fb25a0306d5b14f705396d98c8b926'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 2ade2fc148 [3.12] gh-106300: Improve `assertRaises(Exception)` usages in tests (GH-106302) (GH-106534)
Switched to and reset branch '3.12'

Objects/object.c:2212: _Py_ForgetReference: Assertion failed: invalid object chain
Enable tracemalloc to get the memory block allocation traceback

object address  : 0x7f550fe8dea0
object refcount : 0
object type     : 0x55db5c46aa60
object type name: range
object repr     : <refcnt 0 at 0x7f550fe8dea0>

Fatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailed
Python runtime state: initialized

Thread 0x00007f5524ad86c0 (most recent call first):
  File "<string>", line 10 in subthread
  File "/buildbot/buildarea/3.12.pablogsal-arch-x86_64/build/Lib/threading.py", line 989 in run
  File "/buildbot/buildarea/3.12.pablogsal-arch-x86_64/build/Lib/threading.py", line 1052 in _bootstrap_inner
  File "/buildbot/buildarea/3.12.pablogsal-arch-x86_64/build/Lib/threading.py", line 1009 in _bootstrap

Current thread 0x00007f5526167740 (most recent call first):
  File "/buildbot/buildarea/3.12.pablogsal-arch-x86_64/build/Lib/test/support/threading_helper.py", line 141 in start_threads
  File "/buildbot/buildarea/3.12.pablogsal-arch-x86_64/build/Lib/contextlib.py", line 144 in __exit__
  File "<string>", line 14 in <module>

Extension modules: _testinternalcapi (total: 1)
Debug memory block at address p=0x7f552608de60: API '�'
    18302063728033390045 bytes originally requested
    The 7 pad bytes at p-7 are not all FORBIDDENBYTE (0xfd):
        at p-7: 0xdd *** OUCH
        at p-6: 0xdd *** OUCH
        at p-5: 0xdd *** OUCH
        at p-4: 0xdd *** OUCH
        at p-3: 0xdd *** OUCH
        at p-2: 0xdd *** OUCH
        at p-1: 0xdd *** OUCH
    Because memory is corrupted at the start, the count of bytes requested
       may be bogus, and checking the trailing pad bytes may segfault.
    The 8 pad bytes at tail=0xfdfe7d532406bc3d are Fatal Python error: Segmentation fault

Thread 0x00007f5524ad86c0 (most recent call first):
  File "<string>", line 10 in subthread
  File "/buildbot/buildarea/3.12.pablogsal-arch-x86_64/build/Lib/threading.py", line 989 in run
  File "/buildbot/buildarea/3.12.pablogsal-arch-x86_64/build/Lib/threading.py", line 1052 in _bootstrap_inner
  File "/buildbot/buildarea/3.12.pablogsal-arch-x86_64/build/Lib/threading.py", line 1009 in _bootstrap

Current thread 0x00007f5526167740 (most recent call first):
  File "/buildbot/buildarea/3.12.pablogsal-arch-x86_64/build/Lib/test/support/threading_helper.py", line 141 in start_threads
  File "/buildbot/buildarea/3.12.pablogsal-arch-x86_64/build/Lib/contextlib.py", line 144 in __exit__
  File "<string>", line 14 in <module>

Extension modules: _testcapi, _xxsubinterpreters, _testmultiphase, _testsinglephase, _testinternalcapi (total: 5)
make: *** [Makefile:2015: buildbottest] Segmentation fault (core dumped)

Cannot open file '/buildbot/buildarea/3.12.pablogsal-arch-x86_64/build/test-results.xml' for upload

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Jul 8, 2023
@sobolevn @serhiy-storchaka
pythongh-106300: Improve assertRaises(Exception) usages in tests (p…
2bf595c 
…ythonGH-106302)

(cherry picked from commit 6e6a4cd)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 8, 2023
@serhiy-storchaka @sobolevn
[3.11] pythongh-106300: Improve assertRaises(Exception) usages in t…
88b796f 
…ests (pythonGH-106302).

(cherry picked from commit 6e6a4cd)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Jul 8, 2023
@sobolevn @serhiy-storchaka
[3.11] pythongh-106300: Improve assertRaises(Exception) usages in t…
454a4f8 
…ests (pythonGH-106302).

(cherry picked from commit 6e6a4cd)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

bedevere-bot commented Jul 8, 2023

GH-106545 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 8, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 8, 2023
@serhiy-storchaka @sobolevn
[3.11] gh-106300: Improve assertRaises(Exception) usages in tests (G…
6cd08a5 
…H-106302). (GH-106545)

(cherry picked from commit 6e6a4cd)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

@brettcannon brettcannon

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sobolevn @serhiy-storchaka @bedevere-bot @cjw296 @miss-islington @brettcannon