Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: gh-106593: PyResource API [DO NOT MERGE] #106596

Closed
wants to merge 1 commit into from
Closed

WIP: gh-106593: PyResource API [DO NOT MERGE] #106596

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 10, 2023 •
edited by github-actions bot
Loading

  • Add PyUnicode_AsUTF8Resource()
  • Add PyBytes_AsStringResource()
  • Add PySequence_AsObjectArray()
  • Add Include/pyresource.h
  • Add PyResource_Release() to the stable ABI
  • compute_abstract_methods(): Replace PySequence_Fast() with PySequence_AsObjectArray()

📚 Documentation preview 📚: https://cpython-previews--106596.org.readthedocs.build/

@bedevere-bot bedevere-bot mentioned this pull request Jul 10, 2023
Closed
@vstinner
Copy link
Member Author

Proof-of-Concept PR for issue #106592 PyResource API and issue #106593 PyObject_AsObjectArray() API.

If these issues design is accepted, I will write a clean PR with doc and tests.

@vstinner vstinner mentioned this pull request Jul 10, 2023
Closed
@vstinner
WIP: pythongh-106593: PyResource API
98d883b 
* Add PyUnicode_AsUTF8Resource()
* Add PyBytes_AsStringResource()
* Add PySequence_AsObjectArray()
* Add Include/pyresource.h
* Add PyResource_Close() to the stable ABI
* compute_abstract_methods(): Replace PySequence_Fast()
  with PySequence_AsObjectArray()
@vstinner
Copy link
Member Author

I close my PR: #106593 (comment)

@vstinner vstinner closed this Aug 26, 2023
@vstinner vstinner deleted the seq_asobjarray branch August 26, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @encukou