Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-106572: Convert PyObject_DelAttr() to a function #106611

Merged
merged 1 commit into from
Jul 11, 2023
Merged

gh-106572: Convert PyObject_DelAttr() to a function #106611

merged 1 commit into from
Jul 11, 2023
+40 −15

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 10, 2023 •
edited by github-actions bot
Loading

  • Convert PyObject_DelAttr() and PyObject_DelAttrString() macros to functions.
  • Add PyObject_DelAttr() and PyObject_DelAttrString() functions to the stable ABI.
  • Replace PyObject_SetAttr(obj, name, NULL) with PyObject_DelAttr(obj, name).

📚 Documentation preview 📚: https://cpython-previews--106611.org.readthedocs.build/

@vstinner vstinner requested review from a team and encukou as code owners July 10, 2023 23:00
@bedevere-bot bedevere-bot mentioned this pull request Jul 10, 2023
Closed
@vstinner vstinner mentioned this pull request Jul 10, 2023
Closed
@vstinner
pythongh-106572: Convert PyObject_DelAttr() to a function
aae498b 
* Convert PyObject_DelAttr() and PyObject_DelAttrString() macros to
  functions.
* Add PyObject_DelAttr() and PyObject_DelAttrString() functions to
  the stable ABI.
* Replace PyObject_SetAttr(obj, name, NULL) with
  PyObject_DelAttr(obj, name).
serhiy-storchaka
serhiy-storchaka approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vstinner vstinner merged commit 1f2921b into python:main Jul 11, 2023
19 checks passed
@vstinner vstinner deleted the obj_delattr2 branch July 11, 2023 09:38
@vstinner
Copy link
Member Author

Merged. Thanks for the review @serhiy-storchaka.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@encukou encukou Awaiting requested review from encukou encukou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @serhiy-storchaka @bedevere-bot