gh-89427: Set VIRTUAL_ENV_PROMPT even when VIRTUAL_ENV_DISABLE_PROMPT… #106643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is set The naming of these variables is slightly awkward, but VIRTUAL_ENV_PROMPT just holds the prefix string that gets applied to the prompt. We want to set that variable no matter what, since users who set VIRTUAL_ENV_DISABLE_PROMPT might want to use VIRTUAL_ENV_PROMPT in their own custom prompts.
|
All commit authors signed the Contributor License Agreement. |
|
There is also a older issue that has a comment requesting this feature #79509 (comment) |
vsajip
approved these changes
Jul 13, 2023
vsajip
pushed a commit
that referenced
this pull request
Jan 23, 2024
…H-106726) This improves the implementation in gh-106643. Previously, venv passed "(<prompt>) " to the activation scripts, but we want to provide the original value so that users can inspect it in the $VIRTUAL_ENV_PROMPT env var. Note: Lib/venv/scripts/common/Activate.ps1 surrounded the prompt value with parens a second time, so no change was necessary in that file.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…MPT (pythonGH-106726) This improves the implementation in pythongh-106643. Previously, venv passed "(<prompt>) " to the activation scripts, but we want to provide the original value so that users can inspect it in the $VIRTUAL_ENV_PROMPT env var. Note: Lib/venv/scripts/common/Activate.ps1 surrounded the prompt value with parens a second time, so no change was necessary in that file.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…MPT (pythonGH-106726) This improves the implementation in pythongh-106643. Previously, venv passed "(<prompt>) " to the activation scripts, but we want to provide the original value so that users can inspect it in the $VIRTUAL_ENV_PROMPT env var. Note: Lib/venv/scripts/common/Activate.ps1 surrounded the prompt value with parens a second time, so no change was necessary in that file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is set
The naming of these variables is slightly awkward, but VIRTUAL_ENV_PROMPT just holds the prefix string that gets applied to the prompt. We want to set that variable no matter what, since users who set VIRTUAL_ENV_DISABLE_PROMPT might want to use VIRTUAL_ENV_PROMPT in their own custom prompts.