Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-107017: Analolgy to Pascal and C replaced. #107025

Merged
merged 3 commits into from
Jul 23, 2023
Merged

gh-107017: Analolgy to Pascal and C replaced. #107025

merged 3 commits into from
Jul 23, 2023

Conversation

TommyUnreal
Copy link
Contributor

@TommyUnreal TommyUnreal commented Jul 22, 2023 •
edited by github-actions bot
Loading

Knowledge of arithmetic is more accessible than knowledge of other programming languages. An analogy is, therefore, more accessible.

📚 Documentation preview 📚: https://cpython-previews--107025.org.readthedocs.build/

@TommyUnreal
Analolgy to Pascal and C replaced.
f07a19c 
Knowledge of arithmetic is more accessible than knowledge of other programming languages. An analogy is, therefore, more accessible.
@bedevere-bot bedevere-bot mentioned this pull request Jul 22, 2023
Open
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 22, 2023
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jul 22, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

serhiy-storchaka
serhiy-storchaka reviewed Jul 22, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In mathematics you use ·, ×, : and ÷.

* for multiplication is only used in programming.

@evildmp
Copy link
Contributor

evildmp commented Jul 22, 2023

In mathematics you use ·, ×, : and ÷.

* for multiplication is only used in programming.

It's standard and familiar to most people who use computers - anyone who has used a spreadsheet application, for example. I think that it's also made pretty clear in the examples, which in a tutorial is much more effective than complicating a brief explanation.

hauntsaninja
hauntsaninja reviewed Jul 22, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's true that * and / have so completely won out that a) newcomers from C or Pascal don't need to be told they can be used for arithmetic, b) most people who've used computers would not find this surprising, c) / doesn't really work like C in Python 3

My wording suggestion therefore minimises length

Doc/tutorial/introduction.rst Outdated Show resolved Hide resolved
@TommyUnreal @hauntsaninja
Changed the wording to be more condensed.
dbbf594 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@TommyUnreal
Copy link
Contributor Author

I think it's true that * and / have so completely won out that a) newcomers from C or Pascal don't need to be told they can be used for arithmetic, b) most people who've used computers would not find this surprising, c) / doesn't really work like C in Python 3

My wording suggestion therefore minimises length

Hi! I appreciate your suggestion. I like the wording better as it holds the same information but in a more condensed format.

hugovk
hugovk approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk hugovk merged commit e59da0c into python:main Jul 23, 2023
17 checks passed
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jul 23, 2023
@miss-islington
Copy link
Contributor

Thanks @TommyUnreal for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @TommyUnreal for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-107123 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2023
@TommyUnreal @hauntsaninja @miss-islington
pythongh-107017: Analolgy to Pascal and C replaced. (pythonGH-107025)
2bfa026 
(cherry picked from commit e59da0c)

Co-authored-by: TommyUnreal <45427816+TommyUnreal@users.noreply.github.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 23, 2023
@bedevere-bot
Copy link

GH-107124 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2023
@TommyUnreal @hauntsaninja @miss-islington
pythongh-107017: Analolgy to Pascal and C replaced. (pythonGH-107025)
7baeaa3 
(cherry picked from commit e59da0c)

Co-authored-by: TommyUnreal <45427816+TommyUnreal@users.noreply.github.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 23, 2023
hugovk added a commit that referenced this pull request Jul 23, 2023
@miss-islington @TommyUnreal
@hauntsaninja @hugovk
[3.11] gh-107017: Analolgy to Pascal and C replaced. (GH-107025) (#10…
6138ecd 
…7123)

Co-authored-by: TommyUnreal <45427816+TommyUnreal@users.noreply.github.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Jul 23, 2023
@miss-islington @TommyUnreal @hauntsaninja
[3.12] gh-107017: Analolgy to Pascal and C replaced. (GH-107025) (#10…
e02ddb3 
…7124)

(cherry picked from commit e59da0c)

Co-authored-by: TommyUnreal <45427816+TommyUnreal@users.noreply.github.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 23, 2023
@TommyUnreal @hauntsaninja @jtcave
pythongh-107017: Analolgy to Pascal and C replaced. (python#107025)
610db99 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
@TommyUnreal @hauntsaninja @mementum
pythongh-107017: Analolgy to Pascal and C replaced. (python#107025)
2d648af 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@hauntsaninja hauntsaninja hauntsaninja left review comments

@evildmp evildmp evildmp approved these changes

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TommyUnreal @evildmp @miss-islington @bedevere-bot @hugovk @serhiy-storchaka @hauntsaninja