Clarify documentation about PyVectorcall_Function #107140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation implies that PyVectorcall_NARGS, PyVectorcall_Function, and PyVectorcall_Call were available in Python 3.8. This is half-true - they were available under a different name. I think it's clearer to set the "version added" to 3.9
da-woods
referenced
this pull request
in cython/cython
Jul 23, 2023
…stead of a private function that is now removed in Py3.13.
vstinner
reviewed
Jul 23, 2023
Doc/c-api/call.rst
Outdated
| @@ -140,7 +140,7 @@ Vectorcall Support API | |||
| However, the function ``PyVectorcall_NARGS`` should be used to allow | |||
| for future extensions. | |||
|
|
|||
| .. versionadded:: 3.8 | |||
| .. versionadded:: 3.9 | |||
There was a problem hiding this comment.
PyVectorcall_NARGS() is defined as a static inline function in Python 3.8.0: https://github.com/python/cpython/blob/v3.8.0/Include/cpython/abstract.h#L75
Doc/c-api/call.rst
Outdated
| @@ -164,7 +164,7 @@ Vectorcall Support API | |||
| It does not check the :c:macro:`Py_TPFLAGS_HAVE_VECTORCALL` flag | |||
| and it does not fall back to ``tp_call``. | |||
|
|
|||
| .. versionadded:: 3.8 | |||
| .. versionadded:: 3.9 | |||
There was a problem hiding this comment.
In Python 3.8.0, PyVectorcall_Call() was already defined as a regular function: https://github.com/python/cpython/blob/v3.8.0/Include/cpython/abstract.h#L141
da-woods
changed the title
|
Thanks for the clarification @vstinner - I think I confused myself trying to look at diffs. |
|
Merged, thanks. |
vstinner
added
needs backport to 3.11
|
GH-107173 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 24, 2023
The documentation implies that PyVectorcall_Function() was available in Python 3.8. This is half-true - it was available under a different name. I think it's clearer to set the "version added" to 3.9. (cherry picked from commit 0a9b339) Co-authored-by: da-woods <dw-git@d-woods.co.uk>
|
GH-107174 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 24, 2023
The documentation implies that PyVectorcall_Function() was available in Python 3.8. This is half-true - it was available under a different name. I think it's clearer to set the "version added" to 3.9. (cherry picked from commit 0a9b339) Co-authored-by: da-woods <dw-git@d-woods.co.uk>
vstinner
pushed a commit
that referenced
this pull request
Jul 24, 2023
Fix PyVectorcall_Function doc versionadded (GH-107140) The documentation implies that PyVectorcall_Function() was available in Python 3.8. This is half-true - it was available under a different name. I think it's clearer to set the "version added" to 3.9. (cherry picked from commit 0a9b339) Co-authored-by: da-woods <dw-git@d-woods.co.uk>
vstinner
pushed a commit
that referenced
this pull request
Jul 24, 2023
Fix PyVectorcall_Function doc versionadded (GH-107140) The documentation implies that PyVectorcall_Function() was available in Python 3.8. This is half-true - it was available under a different name. I think it's clearer to set the "version added" to 3.9. (cherry picked from commit 0a9b339) Co-authored-by: da-woods <dw-git@d-woods.co.uk>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Jul 24, 2023
* main: (73 commits) Thoroughly refactor the cases generator (python#107151) Docs: Add missing markup to Argument Clinic docs (python#106876) pythongh-107162: Document errcode.h usage in its comment (python#107177) pythongh-106320: Remove private _PyDict C API (python#107145) Fix PyVectorcall_Function doc versionadded (python#107140) Docs: Remove duplicate word in Argument Clinic howto heading (python#107169) pythongh-107017: Change Chapter Strings to Texts in the Introduction chapter. (python#107104) pythongh-106320: Remove private _PyObject C API (python#107159) Docs: fix typo in os.pwrite docstring (python#107087) pythongh-105291: Add link to migration guide for distutils (python#107130) pythongh-106948: Docs: Disable links for C standard library functions, OS utility functions and system calls (python#107062) pythongh-106320: Remove _PyBytes_Join() C API (python#107144) pythongh-106320: Remove private _PyObject C API (python#107147) pythongh-106320: Remove _PyTuple_MaybeUntrack() C API (python#107143) pythongh-106320: Remove _PyIsSelectable_fd() C API (python#107142) Remove superflous whitespaces in `layout.html`. (pythonGH-107067) pythongh-107122: Update what's news for dbm.*dbm.clear() method (pythongh-107135) pythongh-107122: Add clear method to dbm.ndbm module (pythongh-107126) pythongh-62519: Make pgettext search plurals when translation is not found (python#107118) pythongh-107122: Add clear method to dbm.gdbm.module (pythongh-107127) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation implies that PyVectorcall_Function was available in Python 3.8.
This is half-true - it was available under a different name. I think it's clearer to set the "version added" to 3.9
📚 Documentation preview 📚: https://cpython-previews--107140.org.readthedocs.build/