Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-104683: Argument Clinic: Make most arguments to Class and Function required #107289

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jul 26, 2023

In several cases, this allows us to use simpler type annotations, making the code easier for both type checkers and humans to understand. It also allows us to get rid of a few assertions that were introduced into the code base for purposes of type narrowing, but are now no longer necessary.

@AlexWaygood AlexWaygood changed the title gh-104683: Make most arguments to Class and Function required gh-104683: Argument Clinic: Make most arguments to Class and Function required Jul 26, 2023
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice; thanks!

@AlexWaygood AlexWaygood merged commit 14d074e into python:main Jul 26, 2023
20 checks passed
@AlexWaygood AlexWaygood deleted the clinic-function-simplify branch July 26, 2023 13:28
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants