Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-104580: Put eval_breaker back at the start of the interpreter state. #107383

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jul 28, 2023

Move the eval_breaker back to the start of interpreter state.

People seem to like moving this field, so I've added comments explaining why it should be the first field in the interpreter state.

@markshannon markshannon changed the title GH-104581: Put eval_breaker back at the start of the interpreter state. GH-104580: Put eval_breaker back at the start of the interpreter state. Jul 28, 2023
@markshannon
Copy link
Member Author

@pablogsal you moved this last, AFAICT, so would you mind reviewing?

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for 3.13 as we have now the offset struct 👍

@markshannon markshannon merged commit a1b6795 into python:main Jul 28, 2023
@markshannon markshannon deleted the move-eval-breaker-again branch August 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants