Skip to content

gh-106149: move CFG and basicblock definitions into flowgraph.c, use them as opaque types in compile.c #107639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 10, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 4, 2023

This moves all the code that manipulates the CFG to flowgraph.c.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit c05fa8e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 4, 2023
@iritkatriel
Copy link
Member Author

The ref leaks failures are unrelated to this PR.

@markshannon
Copy link
Member

Looks good to me, although I've not checked every detail as I assume it is a refactor, with no change to behavior.

@iritkatriel Can you confirm that this is strictly a refactor?

@iritkatriel
Copy link
Member Author

@iritkatriel Can you confirm that this is strictly a refactor?

Yes

It basically moves code from compile.c to flowgraph.c, and struct definitions from the header into flowgraph.c, and then changes some of the functions from private (declared in the header) to static in flowgraph.c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants