gh-106368: Improve coverage reports for argument clinic #107693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...
rather thanpass
for empty bodies in abstract methods that are never meant to be executed. Exclude lines consisting solely of...
in our.coveragerc
file.raise AssertionError
instead ofraise RuntimeError
for an exception that's never meant to be executed -- it would indicate a bug inTools/clinic/
itself, rather than an incorrect usage of argument clinic, if that line was ever executed. Excluderaise AssertionError(
lines in our.coveragerc
file.Tools/clinic/cpp.py
was being excluded from coverage reports because it was all inside anif __name__ == "__main__"
block, andif __name__ == "__main__"
blocks are excluded in our.coveragerc
file. That was making our coverage forcpp.py
look better than it actually was. Move that block inside a_main()
function so that it's correctly reported as being uncovered in coverage reports.