gh-93057: Deprecate positional use of optional sqlite3.connect() params

[erlend-aasland]

• Issue: Make optional parameters of sqlite3.connect() keyword-only #93057

---

📚 Documentation preview 📚: https://cpython-previews--107948.org.readthedocs.build/

[serhiy-storchaka]

There is an issue here. Positional parameters are only deprecated in the Connection constructor. But we want also to deprecate them in connect(). Currently you can bypass the deprecations if use the Connection subclass:

class MyConnection(Connection):
    def __init__(self, database, timeout=5.0, ...):
        super().__init__(database, timeout=timeout, ...)

connect(":memory:", 10.0, ..., factory=MyConnection)

But if we add the second deprecation warning in connect(), we will get two deprecation warning.

[erlend-aasland]

There is an issue here. Positional parameters are only deprecated in the Connection constructor. But we want also to deprecate them in connect(). Currently you can bypass the deprecations if use the Connection subclass:

Ah, of course. That's tricky.

[serhiy-storchaka]

Please add a test for connect() and mention this change in What's New and NEWS entries.

It is a wart that we will get two warnings, but there is no simple way to avoid it, except applying deprecations one at a time -- first in connect(), then (since 3.15) in Connection. Not sure if it it is worth.

We can also convert all positional arguments in connect() into keyword arguments for factory. It is a lot of complex code.

[erlend-aasland]

We can also convert all positional arguments in connect() into keyword arguments for factory. It is a lot of complex code.

No, that is a backwards incompatible change.

[erlend-aasland]

mention this change in What's New and NEWS entries.

Is the existing NEWS and What's New entries insufficient? In what way?

[serhiy-storchaka]

Is the existing NEWS and What's New entries insufficient? In what way?

Ah, they already mention connect()! Then simply add "and the Connection constructor".

[erlend-aasland]

Is the existing NEWS and What's New entries insufficient? In what way?

Ah, they already mention connect()! Then simply add "and the Connection constructor".

Yeah, that's useful information. I'll add that; thanks.

[serhiy-storchaka]

LGTM.

[erlend-aasland]

Thanks for the review, Serhiy. Much appreciated.

[erlend-aasland]

@felixxm, sorry, I forgot to ping you; I hope not these deprecations will create havoc for Django.

[felixxm]

@felixxm, sorry, I forgot to ping you; I hope not these deprecations will create havoc for Django.

All good, Django doesn't pass these positional params, only a database name. Thanks 👍