Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-107526: Fix test_module_level_callable_unrepresentable_default #108187

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Aug 21, 2023

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Aug 21, 2023
@corona10 corona10 changed the title no-issue: Fix test_module_level_callable_unrepresentable_default gh-107526: Fix test_module_level_callable_unrepresentable_default Aug 21, 2023
@corona10 corona10 requested a review from sobolevn August 21, 2023 03:47
@corona10 corona10 merged commit 04f7875 into python:main Aug 21, 2023
20 checks passed
@serhiy-storchaka
Copy link
Member

It is not a proper fix. The purpose of the test not testing the signature of getattr(), but testing how pydoc handles such kind of signatures.

I'll write a proper fix.

@corona10 corona10 deleted the fix-pydoc branch August 21, 2023 05:01
@serhiy-storchaka
Copy link
Member

#109325 makes these tests more reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants