gh-108220: Internal header files require Py_BUILD_CORE to be defined #108221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vstinner
commented
Aug 21, 2023
•
vstinner
commented
- pycore_intrinsics.h does nothing if included twice (add #ifndef and #define).
- Update Tools/cases_generator/generate_cases.py to generate the Py_BUILD_CORE test.
- Issue: [C API] Cleanup internal C header files #108220
…fined * pycore_intrinsics.h does nothing if included twice (add #ifndef and #define). * Update Tools/cases_generator/generate_cases.py to generate the Py_BUILD_CORE test.
vstinner
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
_bz2, _lzma, _opcode and zlib extensions now define the Py_BUILD_CORE_MODULE macro to use internal headers (pycore_code.h, pycore_intrinsics.h and pycore_blocks_output_buffer.h).
gvanrossum
reviewed
Aug 21, 2023
Comment on lines
+407
to
+411
| self.out.emit("\n" + textwrap.dedent(""" | ||
| #ifndef Py_BUILD_CORE | ||
| # error "this header requires Py_BUILD_CORE define" | ||
| #endif | ||
| """).strip()) |
There was a problem hiding this comment.
Why bother asking for a review if you're going to merge it while I'm getting coffee? What response time do you expect for reviews?
There was a problem hiding this comment.
Why bother asking for a review
Hmm, I requested the review to you.
There was a problem hiding this comment.
Yeah, I was venting at @vstinner who ignored that and merged eight minutes later. :-(
There was a problem hiding this comment.
I didn't ask for a review on such "cleanup" change. I didn't see that @corona10 asked for a review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.