Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-108216: Cleanup #include in internal header files #108228

Merged
merged 1 commit into from
Aug 21, 2023
Merged

gh-108216: Cleanup #include in internal header files #108228

merged 1 commit into from
Aug 21, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 21, 2023 •
edited by bedevere-bot
Loading

  • Add missing includes
  • Remove unused includes
  • Mention at least once included symbol
  • Sort includes
  • Update Tools/cases_generator/generate_cases.py used to generated pycore_opcode_metadata.h.
  • Update Parser/asdl_c.py used to generate pycore_ast.h.
  • Cleanup also includes in _testcapimodule.c and _testinternalcapi.c.

@vstinner
pythongh-108216: Cleanup #include in internal header files
b001304 
* Add missing includes
* Remove unused includes
* Mention at least once included symbol
* Sort includes
* Update Tools/cases_generator/generate_cases.py used to generated
  pycore_opcode_metadata.h.
* Update Parser/asdl_c.py used to generate pycore_ast.h.
* Cleanup also includes in _testcapimodule.c and _testinternalcapi.c.
@bedevere-bot bedevere-bot mentioned this pull request Aug 21, 2023
Closed
2 tasks
@vstinner vstinner enabled auto-merge (squash) August 21, 2023 18:04
@vstinner vstinner merged commit 0dd3fc2 into python:main Aug 21, 2023
19 checks passed
@vstinner vstinner deleted the cleanup_pycore branch August 21, 2023 18:15
@vstinner
Copy link
Member Author

vstinner commented Aug 21, 2023 •
edited
Loading

Oh, this PR was for the issue #108220

@vstinner vstinner mentioned this pull request Aug 21, 2023
Closed
@erlend-aasland erlend-aasland mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @bedevere-bot