Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-108224: fix doc inconsistency #108230

Merged
merged 1 commit into from
Aug 21, 2023
Merged

gh-108224: fix doc inconsistency #108230

merged 1 commit into from
Aug 21, 2023

Conversation

temach
Copy link
Contributor

@temach temach commented Aug 21, 2023 •
edited by github-actions bot
Loading

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Aug 21, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot mentioned this pull request Aug 21, 2023
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 21, 2023
gvanrossum
gvanrossum approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@temach Are you planning to sign the CLA? (It's just a button to click.)

@gvanrossum gvanrossum added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes and removed skip news labels Aug 21, 2023
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@gvanrossum gvanrossum enabled auto-merge (squash) August 21, 2023 18:02
@gvanrossum gvanrossum merged commit 1cc391d into python:main Aug 21, 2023
25 checks passed
@miss-islington
Copy link
Contributor

Thanks @temach for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-108231 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2023
@temach @miss-islington
pythongh-108224: Fix asyncio doc inconsistency (pythonGH-108230)
e9ee6b3 
(Spawning subprocesses does not require the event loop to run in the main thread -- only signal handling does.)
(cherry picked from commit 1cc391d)

Co-authored-by: temach <tematibr@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Aug 21, 2023
@bedevere-bot
Copy link

GH-108232 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2023
@temach @miss-islington
pythongh-108224: Fix asyncio doc inconsistency (pythonGH-108230)
46061ce 
(Spawning subprocesses does not require the event loop to run in the main thread -- only signal handling does.)
(cherry picked from commit 1cc391d)

Co-authored-by: temach <tematibr@gmail.com>
Yhg1s pushed a commit that referenced this pull request Aug 21, 2023
@miss-islington @temach
[3.12] gh-108224: Fix asyncio doc inconsistency (GH-108230) (#108231)
f51cdfa 
gh-108224: Fix asyncio doc inconsistency (GH-108230)

(Spawning subprocesses does not require the event loop to run in the main thread -- only signal handling does.)
(cherry picked from commit 1cc391d)

Co-authored-by: temach <tematibr@gmail.com>
gvanrossum pushed a commit that referenced this pull request Aug 21, 2023
@miss-islington @temach
[3.11] gh-108224: Fix asyncio doc inconsistency (GH-108230) (#108232)
4d4871e 
(Spawning subprocesses does not require the event loop to run in the main thread -- only signal handling does.)

(cherry picked from commit 1cc391d)

Co-authored-by: temach <tematibr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@temach @bedevere-bot @miss-islington @gvanrossum