Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-108216: Add pycore_dict_struct.h internal header file #108235

Closed
wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 21, 2023

Add a new internal pycore_dict_struct.h header file. It can be used
by debuggers and profilers to inspect a Python dictionary without
having to call Python functions. It should be usable in C++.

pycore_dict.h includes pycore_dict_struct.h (no API change).

Add a new internal pycore_dict_struct.h header file. It can be used
by debuggers and profilers to inspect a Python dictionary without
having to call Python functions. It should be usable in C++.

pycore_dict.h includes pycore_dict_struct.h (no API change).
@vstinner
Copy link
Member Author

@P403n1x87: Would you be able to test that Python 3.13 with this change solves your C++ issue?

@vstinner
Copy link
Member Author

cc @methane @serhiy-storchaka

@P403n1x87
Copy link
Contributor

@P403n1x87: Would you be able to test that Python 3.13 with this change solves your C++ issue?

Yep I'll try to test this as soon as I can. If it works, would this be backportable to 3.12?

@vstinner
Copy link
Member Author

Yep I'll try to test this as soon as I can. If it works, would this be backportable to 3.12?

IMO it's way too late to change Python 3.12, since we are close to the release candidate 1.

@P403n1x87
Copy link
Contributor

@serhiy-storchaka serhiy-storchaka removed the request for review from a team August 28, 2023 09:17
@vstinner
Copy link
Member Author

I closed the issue: #108216 (comment)

@vstinner vstinner closed this Aug 28, 2023
@vstinner vstinner deleted the dict_struct branch August 28, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants