[3.7] bpo-35357: Add _mock_ prefix to name/parent/from_kall attributes of _Call/_MagicProxy. (GH-10873) #10887
+34
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Call/_MagicProxy. (pythonGH-10873) Fix minor typo in test function name. (cherry picked from commit e63e617) Co-authored-by: Andrew Dunai <andunai@gmail.com>
Contributor
Author
1 similar comment
Contributor
Author
|
@cjw296: Please replace |
dsalisbury
added a commit
to dsalisbury/testfixtures
that referenced
this pull request
Jan 2, 2019
In python 3.6.8, 3.7.2, and in python-next, some attributes on the unittest.mock.call object were renamed from things like `name` and `parent` to `_mock_name` and `_mock_parent`. resolves simplistix#102 Python bug: * bpo-35357 (https://bugs.python.org/issue35357) pull requests which added this change: * python/cpython#10873 * python/cpython#10887 * python/cpython#10888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix minor typo in test function name.
(cherry picked from commit e63e617)
Co-authored-by: Andrew Dunai andunai@gmail.com
https://bugs.python.org/issue35357