Skip to content

gh-109390: add dump_symtable utility under #if 0 #109391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 20, 2023
Merged

gh-109390: add dump_symtable utility under #if 0 #109391

merged 4 commits into from
Sep 20, 2023
+110 −1

Conversation

carljm
Copy link
Member

@carljm carljm commented Sep 14, 2023 •
edited
Loading

Sample output for a reasonably large/complex module symtable: https://gist.github.com/carljm/7af75d2b5ea0d5d2f054fdd6c854ff67

I'm sure the output could be made much nicer, but I will leave that as an exercise for future contributors ;)

@bedevere-app bedevere-app bot mentioned this pull request Sep 14, 2023
Closed
JelleZijlstra
JelleZijlstra reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this would have been very helpful.

carljm and others added 2 commits September 14, 2023 07:57
@carljm @JelleZijlstra
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
bb0a0dd 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra
Fix refleaks, add a #define
f0f2cd2
@JelleZijlstra
Copy link
Member

Just pushed some changes:

  • Fixed the refleaks (tested by running test_type_params with -R 3:3)
  • Fixed some compiler warnings
  • Made it so you can simply flip a single #define to dump all symtables, making it easier to use the utility

carljm
carljm commented Sep 18, 2023
View reviewed changes
Copy link
Member Author

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@JelleZijlstra
Add another DECREF, add asserts
Loading
Loading status checks…
aa50592
@carljm
Copy link
Member Author

carljm commented Sep 20, 2023

@JelleZijlstra Thanks for the improvements! Anything else you were wanting to do here, or should I go ahead and merge?

@JelleZijlstra
Copy link
Member

Let's merge it

@carljm carljm merged commit 32ffe58 into python:main Sep 20, 2023
@carljm carljm deleted the symdump branch September 20, 2023 16:56
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@carljm @JelleZijlstra @csm10495
pythongh-109390: add dump_symtable utility under #if 0 (python#109391)
7611b2b 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@carljm @JelleZijlstra @Glyphack
pythongh-109390: add dump_symtable utility under #if 0 (python#109391)
ac6772b 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carljm @JelleZijlstra