Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-109461: Update logging module lock acquisition to use context manager #109462

Merged
merged 41 commits into from
Sep 27, 2023
Merged

gh-109461: Update logging module lock acquisition to use context manager #109462

merged 41 commits into from
Sep 27, 2023

Commits on Sep 15, 2023

  1. Updated logging __init__.py to acquire its module lock using a contex… 

    …t manager so that it is safer and easier to use.
    @dcollison
    dcollison committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    02c1d58 View commit details
    Browse the repository at this point in the history

  2. 📜🤖 Added by blurb_it.

    @blurb-it
    blurb-it[bot] authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    f319ab0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into pythongh-109461-update-logging-lock-acquisition

    @dcollison
    dcollison authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    6664c4c View commit details
    Browse the repository at this point in the history

  4. Updated to leave the existing API alone and added a new method _acqui… 

    …reModuleLock
    @dcollison
    dcollison committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    fd635b2 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/pythongh-109461-update-logging-l… 

    …ock-acquisition' into pythongh-109461-update-logging-lock-acquisition
    @dcollison
    dcollison committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    749b678 View commit details
    Browse the repository at this point in the history

  6. Updated acquireLock usages to acquireModuleLock

    @dcollison
    dcollison committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    e5ad43b View commit details
    Browse the repository at this point in the history

  7. Removed unnecessary changes

    @dcollison
    dcollison committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0a2bb5f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into pythongh-109461-update-logging-lock-acquisition

    @dcollison
    dcollison authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    ea33592 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into pythongh-109461-update-logging-lock-acquisition

    @dcollison
    dcollison authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    af9f7d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. Updated _acquireModuleLock() to _get_lock() which gets the lock's con… 

    …text manager, or a null context.
    @dcollison
    dcollison committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    4f2d1c1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/pythongh-109461-update-logging-l… 

    …ock-acquisition' into pythongh-109461-update-logging-lock-acquisition
    @dcollison
    dcollison committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    dc7df1e View commit details
    Browse the repository at this point in the history

  3. Updated comments

    @dcollison
    dcollison committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    892a5cb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into pythongh-109461-update-logging-lock-acquisition

    @dcollison
    dcollison authored Sep 16, 2023
    Configuration menu
    Copy the full SHA
    a30d5da View commit details
    Browse the repository at this point in the history

  5. Updated blurb

    @dcollison
    dcollison committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    cf7a2e6 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/pythongh-109461-update-logging-l… 

    …ock-acquisition' into pythongh-109461-update-logging-lock-acquisition
    @dcollison
    dcollison committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    0a53f3b View commit details
    Browse the repository at this point in the history

  7. Removed unused import

    @dcollison
    dcollison committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    2760cc5 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Merge branch 'main' into pythongh-109461-update-logging-lock-acquisition

    @dcollison
    dcollison authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b5e6651 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Updated __init__.py to remove _get_lock() and "if _lock" checks since… 

    … bool(_lock) always returns true
    @dcollison
    dcollison authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    7f3b28a View commit details
    Browse the repository at this point in the history

  2. Changed "with logging._get_lock():" to "with logging._lock:"

    @dcollison
    dcollison authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    09c9133 View commit details
    Browse the repository at this point in the history

  3. Changed "with logging._get_lock()" to "with logging._lock:"

    @dcollison
    dcollison authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    9f3607e View commit details
    Browse the repository at this point in the history

  4. Changed "with logging._get_lock():" to "with logging._lock:"

    @dcollison
    dcollison authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    b15e4bf View commit details
    Browse the repository at this point in the history

  5. Update __init__.py

    @dcollison
    dcollison authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    a0c50bf View commit details
    Browse the repository at this point in the history

  6. Update Misc/NEWS.d/next/Library/2023-09-15-17-12-53.gh-issue-109461.V… 

    …NFPTK.rst

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
    @dcollison @AA-Turner
    dcollison and AA-Turner authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    9d0675b View commit details
    Browse the repository at this point in the history

  7. Update __init__.py

    @dcollison
    dcollison authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    a298a7b View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into pythongh-109461-update-logging-lock-acquisition

    @dcollison
    dcollison authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    1b14732 View commit details
    Browse the repository at this point in the history

  9. Updated handlers to use a context manager for lock acquisition

    @dcollison
    dcollison committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    1979a75 View commit details
    Browse the repository at this point in the history

  10. Updated handlers to use a context manager for lock acquisition

    @dcollison
    dcollison committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    3fd33ef View commit details
    Browse the repository at this point in the history

  11. Copying _lock to local variable

    @dcollison
    dcollison committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    22c868e View commit details
    Browse the repository at this point in the history

  12. Updated another lock acquisition

    @dcollison
    dcollison committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    335f814 View commit details
    Browse the repository at this point in the history

  13. Update Misc/NEWS.d/next/Library/2023-09-15-17-12-53.gh-issue-109461.V… 

    …NFPTK.rst

Co-authored-by: Victor Stinner <vstinner@python.org>
    @dcollison @vstinner
    dcollison and vstinner authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    afa79ef View commit details
    Browse the repository at this point in the history

  14. Merge branch 'main' into pythongh-109461-update-logging-lock-acquisition

    @dcollison
    dcollison authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    600a126 View commit details
    Browse the repository at this point in the history

  15. Someone managed to duplicate a line in the docstring

    @dcollison
    dcollison committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    5e92580 View commit details
    Browse the repository at this point in the history

  16. Merge remote-tracking branch 'origin/pythongh-109461-update-logging-l… 

    …ock-acquisition' into pythongh-109461-update-logging-lock-acquisition
    @dcollison
    dcollison committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    20e46f6 View commit details
    Browse the repository at this point in the history

  17. Someone managed to duplicate a line in the docstring

    @dcollison
    dcollison committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    c73e2b7 View commit details
    Browse the repository at this point in the history

  18. Reverted Handler acquire() and release() as it actually needs the Non… 

    …e check
    @dcollison
    dcollison committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    a9472c7 View commit details
    Browse the repository at this point in the history

  19. Merge branch 'main' into pythongh-109461-update-logging-lock-acquisition

    @dcollison
    dcollison authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    df75801 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Added comment to _acquireLock() to justify the try-except block aroun… 

    …d lock acquisition
    @dcollison
    dcollison committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    bca5ae8 View commit details
    Browse the repository at this point in the history

  2. Renamed "_acquireLock" to "_prepareFork" and "_releaseLock" to "_afte… 

    …rFork" and updated docstrings
    @dcollison
    dcollison committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    1ba5979 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into pythongh-109461-update-logging-lock-acquisition

    @dcollison
    dcollison authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    c1a9651 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into pythongh-109461-update-logging-lock-acquisition

    @dcollison
    dcollison authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    efd7462 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Merge branch 'main' into pythongh-109461-update-logging-lock-acquisition

    @AA-Turner
    AA-Turner authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    797ae0d View commit details
    Browse the repository at this point in the history